Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow changing the base URL the ccm uses for API calls #88

Merged
merged 1 commit into from
May 6, 2022
Merged

Allow changing the base URL the ccm uses for API calls #88

merged 1 commit into from
May 6, 2022

Conversation

ddymko
Copy link
Contributor

@ddymko ddymko commented May 5, 2022 •
edited

Description

Allow changing of the base URL that the ccm uses to connect to the vultr API

Logs from when I change the base URL to google

May 05 17:02:33 vultr vultr-cloud-controller-manager[14203]: E0505 17:02:33.526659   14203 controller.go:310] error processing service default/vultr-lb-https (will retry): failed to ensure load balancer: <!DOCTYPE html>
May 05 17:02:33 vultr vultr-cloud-controller-manager[14203]: <html lang=en>
May 05 17:02:33 vultr vultr-cloud-controller-manager[14203]:   <meta charset=utf-8>
May 05 17:02:33 vultr vultr-cloud-controller-manager[14203]:   <meta name=viewport content="initial-scale=1, minimum-scale=1, width=device-width">
May 05 17:02:33 vultr vultr-cloud-controller-manager[14203]:   <title>Error 404 (Not Found)!!1</title>
May 05 17:02:33 vultr vultr-cloud-controller-manager[14203]:   <style>
May 05 17:02:33 vultr vultr-cloud-controller-manager[14203]:     *{margin:0;padding:0}html,code{font:15px/22px arial,sans-serif}html{background:#fff;color:#222;padding:15px}body{margin:7% auto 0;max-width:390px;min-height:180px;padding:30px 0 15px}* > body{background:url(//www.google.com/images/errors/robot.png) 100% 5px no-repeat;padding-right:205px}p{margin:11px 0 22px;overflow:hidden}ins{color:#777;text-decoration:none}a img{border:0}@media screen and (max-width:772px){body{background:none;margin-top:0;max-width:none;padding-right:0}}#logo{background:url(//www.google.com/images/branding/googlelogo/1x/googlelogo_color_150x54dp.png) no-repeat;margin-left:-5px}@media only screen and (min-resolution:192dpi){#logo{background:url(//www.google.com/images/branding/googlelogo/2x/googlelogo_color_150x54dp.png) no-repeat 0% 0%/100% 100%;-moz-border-image:url(//www.google.com/images/branding/googlelogo/2x/googlelogo_color_150x54dp.png) 0}}@media only screen and (-webkit-min-device-pixel-ratio:2){#logo{background:url(//www.google.com/images/branding/googlelogo/2x/googlelogo_color_150x54dp.png) no-repeat;-webkit-background-size:100% 100%}}#logo{display:inline-block;height:54px;width:150px}
May 05 17:02:33 vultr vultr-cloud-controller-manager[14203]:   </style>
May 05 17:02:33 vultr vultr-cloud-controller-manager[14203]:   <a href=//www.google.com/><span id=logo aria-label=Google></span></a>
May 05 17:02:33 vultr vultr-cloud-controller-manager[14203]:   <p><b>404.</b> <ins>That’s an error.</ins>
May 05 17:02:33 vultr vultr-cloud-controller-manager[14203]:   <p>The requested URL &lt;code&gt;/v2/load-balancers&lt;/code&gt; was not found on this server.  &lt;ins&gt;That’s all we know.&lt;/ins&gt;
May 05 17:02:33 vultr vultr-cloud-controller-manager[14203]: I0505 17:02:33.526716   14203 event.go:291] "Event occurred" object="default/vultr-lb-https" kind="Service" apiVersion="v1" type="Warning" reason="SyncLoadBalancerFailed" message="Error syncing load balancer: failed to ensure load balancer: &lt;!DOCTYPE html&gt;\n&lt;html lang=en&gt;\n  &lt;meta charset=utf-8&gt;\n  &lt;meta name=viewport content=\"initial-scale=1, minimum-scale=1, width=device-width\"&gt;\n  &lt;title&gt;Error 404 (Not Found)!!1&lt;/title&gt;\n  &lt;style&gt;\n    *{margin:0;padding:0}html,code{font:15px/22px arial,sans-serif}html{background:#fff;color:#222;padding:15px}body{margin:7% auto 0;max-width:390px;min-height:180px;padding:30px 0 15px}* &gt; body{background:url(//www.google.com/images/errors/robot.png) 100% 5px no-repeat;padding-right:205px}p{margin:11px 0 22px;overflow:hidden}ins{color:#777;text-decoration:none}a img{border:0}@media screen and (max-width:772px){body{background:none;margin-top:0;max-width:none;padding-right:0}}#logo{background:url(//www.google.com/images/branding/googlelogo/1x/googlelogo_color_150x54dp.png) no-repeat;margin-left:-5px}@media only screen and (min-resolution:192dpi){#logo{background:url(//www.google.com/images/branding/googlelogo/2x/googlelogo_color_150x54dp.png) no-repeat 0% 0%/100% 100%;-moz-border-image:url(//www.google.com/images/branding/googlelogo/2x/googlelogo_color_150x54dp.png) 0}}@media only screen and (-webkit-min-device-pixel-ratio:2){#logo{background:url(//www.google.com/images/branding/googlelogo/2x/googlelogo_color_150x54dp.png) no-repeat;-webkit-background-size:100% 100%}}#logo{display:inline-block;height:54px;width:150px}\n  &lt;/style&gt;\n  &lt;a href=//www.google.com/&gt;&lt;span id=logo aria-label=Google&gt;&lt;/span&gt;&lt;/a&gt;\n  &lt;p&gt;&lt;b&gt;404.&lt;/b&gt; &lt;ins&gt;That’s an error.&lt;/ins&gt;\n  &lt;p&gt;The requested URL &lt;code&gt;/v2/load-balancers&lt;/code&gt; was not found on this server.  &lt;ins&gt;That’s all we know.&lt;/ins&gt;\n"

Related Issues

Checklist:

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you linted your code locally prior to submission?
  • Have you successfully ran tests with your changes locally?

@ddymko ddymko added the enhancement New feature or request label May 5, 2022
@ddymko ddymko merged commit c1fbb45 into vultr:master May 6, 2022
@ddymko ddymko deleted the api-override branch May 6, 2022 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afady afady afady approved these changes

Assignees

@afady afady

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ddymko @afady