Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an options parameter to pass to a Trainer #17

Merged
merged 1 commit into from Mar 5, 2020
Merged

Add an options parameter to pass to a Trainer #17

merged 1 commit into from Mar 5, 2020

Conversation

mathquis
Copy link
Contributor

@mathquis mathquis commented Mar 4, 2020

with a debug property to avoid writing logs to stdout.

@vunb
Copy link
Owner

vunb commented Mar 4, 2020

Thank you for the PR 👍

@vunb vunb self-requested a review March 5, 2020 03:42
vunb
vunb approved these changes Mar 5, 2020
View reviewed changes
Copy link
Owner

@vunb vunb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes should update both the document and the type definition (index.d.ts)

@vunb vunb merged commit c11c811 into vunb:master Mar 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vunb vunb vunb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mathquis @vunb