Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade node-sass and react-scripts so they work with node 16 (lts) #3

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

johanhelsing-attensi
Copy link

@johanhelsing-attensi johanhelsing-attensi commented May 12, 2022

@binarynate
Copy link
Member

Hi, @johanhelsing-attensi 👋. I'm sorry for my extremely delayed response! I totally missed this PR and only saw it just now because I'm about to fix a bug in the keyboard. I tested your branch with Node v16.17.0, but I found that it's not working for me on macOS 12.5 w/ Xcode 14 because the native node-sass library fails to compile. For reference, I attached
the log from running npm install. So, for now I'm going to keep using nvm use 8 to use Node 8 like described in the README, but I will look into upgrading the project's dependencies in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants