Fix lexer_read_on_line returning empty tokens at EOF #25
+1
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At EOF, lexer_read() returns 0 and an empty token.
While this is supposedly taken care of by the if statement it is called
in, the statement falls through and reaches the following
if (!tok.line_crossed)
which may evaluate to true (UB due to line_crossed being undefined)
and consequently return empty tokens indefinitely.
|
Thanks for the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At EOF,
lexer_read()returns 0 and an empty token.While this is supposedly taken care of by the if statement it is called in, the statement falls through and reaches the following
if (!tok.line_crossed)which may evaluate to true (UB due to line_crossed being uninitialized) and consequently return empty tokens indefinitely.This PR/commit fixes that by returning early.
Most likely an oversight really.