Generate info about teachers in subject rooms #996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
solumath
reviewed
Apr 12, 2024
solumath
reviewed
Apr 12, 2024
solumath
reviewed
Apr 12, 2024
solumath
reviewed
Apr 12, 2024
solumath
reviewed
Apr 12, 2024
fix: Replace dev values with those on production feat: Send one message per channel, add comments docs: update TODO refactor: rename command
refactor: Split most of the logic into separate functions docs: Add command description refactor: Use embed description instead of field refactor: use list, tuple, callablestring, cachedproperty refactor: Use @cached_property for teacher_info_channel feat: Don't ping, add full names refactor: Remove TODOs
1ukastesar
force-pushed
the
vyucujici-info
branch
from
cb99e3e
to
1d3b3a1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR type
Description
Automatically generate info about teachers in subject rooms to
#vyucujici-info.Related Issue(s)
Closes #506
After checks
Post deployment
UI changes