Minor issues.

[ichik]

Hi, thanks for this incredible work that you've done. I have a few minor issues and suggestions:

1. When running CLI against a test Figma file I'm seeing duplicate outputs for prefer-local-style rule, error message is just repeated twice
2. Contrast ratio is only checked for master components, but not the instances which may contain overridden properties with inaccessible combinations applied. Checking generally against instances (and just frames in general) may be more useful, especially considering Figma librarires functionality
3. I couldn't trigger the must-be-in-frame error in my sample file, the rule should be checking all immediate children of the canvas or am I not understanding how that should work?

[vutran]

Contrast ratio is only checked for master components, but not the instances which may contain overridden properties with inaccessible combinations applied. Checking generally against instances (and just frames in general) may be more useful, especially considering Figma librarires functionality

This makes sense. The reason why I chose to limit it to only Components is to enforce fixes be made on the Component itself. The goal is to ensure designers are reusing as much colors/styles/components and expanding this to run against overridden properties otherwise it doesn't truly solve the problem of hundreds of color/style variations. Stated, these overridden properties should actually trigger the prefer-local-styles error.

I couldn't trigger the must-be-in-frame error in my sample file, the rule should be checking all immediate children of the canvas or am I not understanding how that should work?

This is correct. Do mind sharing a gist of a Figma structure that replicates these issues? You should be able to obtain this directly from the API or can just DM me a link to your project and I can take a look at some of these issues.

[ichik]

Just take a look at this, it's a simple file with only rectangle on a canvas. If I understand correctly it should trigger must-be-in-frame, but I'm only seeing errors for prefer-local-style.

[vutran]

Closing as the provided Figma link is invalid. Please re-open with updated link if the problem still persists.