Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add function for adding security options #12

Merged
merged 3 commits into from
Dec 11, 2021
Merged

Conversation

sonicrules1234
Copy link
Contributor

Add function for adding security options.

What did you implement:

  • Function to add security options

How did you verify your change:

Used the function with vec!["seccomp=unconfined".into()]

What (if anything) would need to be called out in the CHANGELOG for the next release:

Maybe mention the function was added.

Add function for adding security options.
Copy link
Owner

@vv9k vv9k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your submission! :) I left a comment with some requested changes.

src/api/container/opts.rs Outdated Show resolved Hide resolved
Change so that we use the impl_vec_field macro
src/api/container/opts.rs Outdated Show resolved Hide resolved
@vv9k
Copy link
Owner

vv9k commented Dec 11, 2021

LGTM, thanks! :)

@vv9k vv9k merged commit e02eaae into vv9k:master Dec 11, 2021
@sonicrules1234
Copy link
Contributor Author

Can you publish this to crates.io? I'm using it in my project, and it needs a version number in order for me to publish.

@vv9k
Copy link
Owner

vv9k commented Dec 12, 2021

Sure thing, it's been a week since the last release so I uploaded version 0.8.0 to crates.io.

@sonicrules1234
Copy link
Contributor Author

Thanks. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants