fix(provider): read TS Lint indent size #134
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The TS Lint [`indent` rule](https://palantir.github.io/tslint/rules/indent/) can specify the indentation size: ``` "indent": [true, "spaces"] ``` ``` "indent": [true, "spaces", 4] ``` ``` "indent": [true, "tabs", 2] ``` This patch allows `tsfmt` to read that size and correctly set the formatting options. This means that `tslint` and `tsfmt` do not fight over the indentation size.
|
@vvakame not sure if the travis error is a result of this patch? |
|
@vvakame any chance you could have a look at this? Would be a really good quality of life improvement for the project; means that with a I'm not sure why |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The TS Lint
indentrule can specify the indentation size:This patch allows
tsfmtto read that size and correctly set the formatting options. This means thattslintandtsfmtdo not fight over the indentation size.