New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Index level metrics #131
Index level metrics #131
Conversation
@vvanholl PTAL I need your review. I do not like creating massive PRs. The next feature I will contribute is #124 and it would be really great if this PR is already merged before I submit next one. We also need back-port these changes into older releases. So there is a lot of work to do... Let me sum up what this PR brings:
In general I think it will be useful to add REST tests for every exposed metric. In the future I want to make sure that there is also Grafana dashboard available for each release version of this plugin. For this I want to be sure all the used metric names match. |
Just note: if you wan to run all tests use |
As usual this is a very awesome contribution to my project :) Vincent. By the way, from now CI will also done by Gitlab CI. |
This is great news! I am trying to learn more about Gitlab CI ATM. Does the CI start when PR is created? I created #132 but it does not seem to kickstart CI. Is there anything we can do about this? Also it would be nice to add project badges to README.dm. I was able to figure out build badge for the Though coverage badge does not seem to work for me: I need to dig deeper. Thoughts welcome. |
Hmm... is it possible that Gitlab-CI does not support easy pipeline start when new PR is created in GitHub? See https://stackoverflow.com/questions/43918324/trigger-jobs-in-gitlab-ci-on-merge-request |
Unfortunately this is not yet implemented as well : https://gitlab.com/gitlab-org/gitlab-ce/issues/23902 |
Adding esplugin integaration tests.
Bring indices level metrics back.