Endpoint summary #12
Merged
Endpoint summary #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
churnikov
approved these changes
Jul 20, 2021
| тоже удаляем такие документы. | ||
| создать на коллекции уникальный индекс, который привязан к уникальному полю документа. В нашем | ||
| случае им является поле `CID`. | ||
| * |
molecad/api_db.py
Outdated
Comment on lines
9
to
10
| # TODO | ||
| # settings = Settings(_env_file="prod.env", _env_file_encoding="utf-8") |
molecad/api_db.py
Outdated
| return list(cursor) | ||
|
|
||
|
|
||
| def summary_search(smiles) -> List[Summary]: |
There was a problem hiding this comment.
Suggested change
| def summary_search(smiles) -> List[Summary]: | |
| def summary_search(smiles: str) -> List[Summary]: |
molecad/downloader_types.py
Outdated
| from enum import Enum | ||
| from typing import TypeVar | ||
| import enum | ||
| import typing as t |
There was a problem hiding this comment.
Почему?
Это может запутать в будущем, лучше не делай так
There was a problem hiding this comment.
ок, просто увидела где-то, решила попробовать, но мне не понравилось
molecad/settings.py
Outdated
| @@ -19,7 +19,7 @@ class Settings(BaseSettings): | |||
| split_dir = Field("./data/split", env="SPLIT_DIR") | |||
|
|
|||
| component_name = "molecad" | |||
| api_version: str = "/v0" | |||
| api_version: str = "/v1" | |||
There was a problem hiding this comment.
Мы, вроде, всё ещё api v0 делаем
There was a problem hiding this comment.
ну у тебя так на конфлюэнсе написано в названии ручки
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ручка
/v1/compound/summary