[Stride] Changes the pin types of ColorMap, ColorIn (and others) to GPU<RGBA>
#644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azeno
added
VL.Stride
|
azeno
force-pushed
the
dev/compute-color-support
branch
from
7eb40c1
to
a1a6ecc
Compare
azeno
force-pushed
the
dev/switch-to-gpu-of-rgba
branch
from
8cd357b
to
8ef599b
Compare
azeno
force-pushed
the
dev/compute-color-support
branch
from
a1a6ecc
to
33f7cf2
Compare
azeno
force-pushed
the
dev/switch-to-gpu-of-rgba
branch
from
8ef599b
to
79001c8
Compare
|
#652 should be merged first before continuing work on this one. |
…rawShader` to `GPU<RGBA>` This commit is a breaking change. It probably requires more thought on how it affects other nodes and we need to ensure that conversion nodes from/to Vector4 & RGBA are present. Consider this commit WIP.
azeno
force-pushed
the
dev/switch-to-gpu-of-rgba
branch
from
79001c8
to
2008364
Compare
|
fixed
done
moved
done (bdc6913)
no, use new Convert (RGBAToVector4) for that
use new Convert (RGBAToVector4) |
|
…rgba # Conflicts: # VL.Stride.Runtime/VL.Stride.Rendering.TextureFX.vl
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Details
Description
This PR contains breaking changes as it changes the type on well knows nodes like
ColorMapandColorInas well as internal sink nodes likeComposeDrawShader.There are probably even more places where the type should be changed to
GPU<RGBA>. We should further ensure that conversion nodes from RGBA and Color4 are present. Note that those nodes will be a no-op on GPU side.Related Issue
#643
Motivation and Context
Once we start add/change shaders to make use of
GPU<RGBA>pins it's only logical to be able to connect those pins to the obvious candidates such asColorMaporColorIn. Also sink nodes composing a pixel shader should express their intent by using this new pin type.Types of changes
Checklist