Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace_vars will break media-queries #100

Closed
tijsverkoyen opened this issue Jan 12, 2013 · 2 comments
Closed

replace_vars will break media-queries #100

tijsverkoyen opened this issue Jan 12, 2013 · 2 comments

Comments

@tijsverkoyen
Copy link
Contributor

In the convertscript there is a method replace_vars which replaces @ with $, but this brakes media queries.

I think it should check if the string after the @ isn't media or page.
@tijsverkoyen
Copy link
Contributor Author

Also not -ms-keyframes or -o-keyframes

vwall added a commit that referenced this issue Jan 13, 2013
@vwall
don't replace keyframes in convert #100
7c25682
@vwall
Copy link
Owner

vwall commented Jan 13, 2013

Fixed in the 3.0 branch. Will backport.

@vwall vwall closed this as completed Jan 13, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vwall @tijsverkoyen