Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to padded table cells #16

Closed
vweevers opened this issue Jun 23, 2018 · 1 comment
Closed

Switch to padded table cells #16

vweevers opened this issue Jun 23, 2018 · 1 comment
Assignees
@vweevers
Projects
hallmark
Milestone
0.0.1

Comments

@vweevers
Copy link
Owner

vweevers commented Jun 23, 2018 •
edited

I opted to disabling table cell padding in remark-stringify, because it lessens diff noise, especially on big generated tables.

But the relevant lint plugin (remark-lint-table-cell-padding) only has the padded and compact modes. Compact is almost what I want, but it doesn't allow a space between pipes (|) and content.

In addition, remark-contributors generates padded tables.

So for now I'll switch to padded tables, and configure remark-lint-table-cell-padding with padded mode.

FYI @ralphtheninja
@vweevers vweevers added this to the 0.0.1 milestone Jun 23, 2018
@vweevers vweevers self-assigned this Jun 23, 2018
@vweevers vweevers added this to Backlog in hallmark via automation Jun 23, 2018
@vweevers vweevers moved this from Backlog to Todo in hallmark Jun 23, 2018
@vweevers vweevers moved this from Todo to In Progress in hallmark Jun 23, 2018
@vweevers
Copy link
Owner Author

258483a

hallmark automation moved this from In Progress to Done Jun 23, 2018
vweevers added a commit that referenced this issue Aug 31, 2019
@vweevers
Allow disabling table padding
3210a96 
Because on big tables it creates noise.

Setting "paddedTable" to "false" in package.json does 3 things:

1. Disable padding by `remark-stringify`
2. Use fixed width columns: `| --- | --- |`
3. Disable `remark-lint-table-cell-padding`

Linting is disabled because `remark-lint-table-cell-padding` has
no option (yet) for this particular style.

See: remarkjs/remark-lint#217

Prior discussion: #16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vweevers vweevers

Labels
None yet
Projects
hallmark
  
Done
Milestone
0.0.1
Development

No branches or pull requests
1 participant
@vweevers