Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace remark-toc #36

Closed
vweevers opened this issue Aug 23, 2019 · 0 comments · Fixed by #118
Closed

Replace remark-toc #36

vweevers opened this issue Aug 23, 2019 · 0 comments · Fixed by #118
Projects
hallmark

Comments

@vweevers
Copy link
Owner

vweevers commented Aug 23, 2019 •
edited
Loading

The ToC is too opinionated. Write a replacement plugin that:

  1. Can both lint and fix the ToC
  2. Recognizes a ToC wrapped in <details>. This will remove the need for remark-collapse here.
  3. Auto-detects the depth of the existing ToC (if any) and lints & fixes accordingly.
@vweevers vweevers added the question Support or open question(s) label Aug 23, 2019
@vweevers vweevers added this to Backlog in hallmark via automation Aug 23, 2019
@vweevers vweevers changed the title Make ToC opt-in Replace automatic ToC insertion with linter only Aug 30, 2019
@vweevers vweevers removed the question Support or open question(s) label Aug 30, 2019
@vweevers vweevers mentioned this issue Aug 30, 2019
Closed
@vweevers vweevers changed the title Replace automatic ToC insertion with linter only Replace remark-toc Aug 31, 2019
vweevers added a commit that referenced this issue Apr 6, 2024
@vweevers
Breaking: remove remark-toc plugin
4d9c10a 
If you have a "Table of Contents" section in your README, it will
no longer be automatically updated. Either remove it, or add the
plugin to hallmark configuration.

Ref: #38
Closes: #36
Category: removal
@vweevers vweevers mentioned this issue Apr 6, 2024
Merged
vweevers added a commit that referenced this issue Apr 6, 2024
@vweevers
Breaking: remove remark-toc plugin (#118)
19f4a8f 
If you have a "Table of Contents" section in your README, it will
no longer be automatically updated. Either remove it, or add the
plugin to hallmark configuration.

Ref: #38
Closes: #36
Category: removal
hallmark automation moved this from Backlog to Done Apr 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
hallmark
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Breaking: remove remark-toc plugin vweevers/hallmark
1 participant
@vweevers