Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase/Decrease Pan/Tilt Speed not immediately effective #11

Closed
vwout opened this issue Feb 18, 2023 · 11 comments
Closed

Increase/Decrease Pan/Tilt Speed not immediately effective #11

vwout opened this issue Feb 18, 2023 · 11 comments

Comments

@vwout
Copy link
Owner

vwout commented Feb 18, 2023

Yesterday, when using the PTZOptics mode, I found that the "Increase Pan/Tilt Speed" adn "Decrease Pan/Tilt Speed"(A) did not take effect immediately on the camera. I need to press the refresh button(C) in the lower left corner to take effect, but the value here has changed(B).

微信图片_20230218090822

微信图片_20230218090732

Originally posted by @PoWeR-Ding in #8 (comment)

@vwout
Copy link
Owner Author

vwout commented Feb 18, 2023

The speed increase/decrease shortcuts actually do have immediate effect. This is only shown in the settings after reload - this is a limitation of OBS.
The speed however was only applied at the first hotkey use. Changing the speed afterwards has no effect until the plugin is reloaded. This bug is resolved in 33c621a.

@PoWeR-Ding
Copy link

OK, copy. I will test as soon as possible

@PoWeR-Ding
Copy link

微信截图_20230219235750
微信图片_20230219235509

Hello, I can't control the camera after updating the script.

@PoWeR-Ding
Copy link

Now, after changing the speed, it will take effect immediately. But the up, down, left and right directions cannot be controlled.

微信截图_20230220001321

@PoWeR-Ding
Copy link

"Zoom In" and "Zoom Out" are also normal. √

@vwout
Copy link
Owner Author

vwout commented Feb 19, 2023

Sorry about that; my fix was too quick (not properly tested). Should be resolved now.

@PoWeR-Ding
Copy link

Never mind, I will continue to test😂😂

@PoWeR-Ding
Copy link

微信截图_20230220091752
Script Log.txt

This time, "Zoom In" and "Zoom Out" will not take effect. 😣 😣 😣 😣

@vwout
Copy link
Owner Author

vwout commented Feb 20, 2023

Now it should finally work - without breaking stuff.
This finally made me start on writing unit tests for the OBS plugin script as well ...

@PoWeR-Ding
Copy link

Thanks for the patient repair. I will continue to test it.

@PoWeR-Ding
Copy link

Good morning, vwut

I tested it again and there was no problem.

Thanks again.

@vwout vwout closed this as completed Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants