Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ppo.py documentation #120

Merged
merged 7 commits into from Feb 26, 2022
Merged

Add ppo.py documentation #120

merged 7 commits into from Feb 26, 2022

Conversation

vwxyzjn
Copy link
Owner

@vwxyzjn vwxyzjn commented Feb 22, 2022

This PR adds more PPO documentation and tracked experiments.

Checklist for ppo.py:

  • I've read the CONTRIBUTION guide (required).
  • I have ensured pre-commit run --all-files passes (required).
  • I have contacted @vwxyzjn to obtain access to the cleanrl W&B team (required).
  • I have tracked applicable experiments in cleanrl/benchmark with --capture-video flag toggled on (required).
  • I have updated the documentation accordingly.
    • I have explained note-worthy implementation details.
    • I have added links to the original paper and related papers (if applicable).
    • I have added links to the PR related to the algorithm.
    • I have created a table comparing my results against those from reputable sources (i.e., the original paper or other reference implementation).
    • I have added the learning curves.
    • I have added links to the tracked experiments.
  • I have updated the tests accordingly (if applicable).

@gitpod-io
Copy link

gitpod-io bot commented Feb 22, 2022

@vercel
Copy link

vercel bot commented Feb 22, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/vwxyzjn/cleanrl/GsqzdrsLbvPGBP9hU4F2j22DRVvt
✅ Preview: https://cleanrl-git-ppo-docs-vwxyzjn.vercel.app

@vwxyzjn vwxyzjn changed the title Add PPO documetnation Add ppo.py documetnation Feb 22, 2022
@vwxyzjn
Copy link
Owner Author

vwxyzjn commented Feb 26, 2022

Merging as is but happy to revisit.

@vwxyzjn vwxyzjn merged commit b63315b into master Feb 26, 2022
@vwxyzjn vwxyzjn changed the title Add ppo.py documetnation Add ppo.py documentation Feb 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant