Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DDPG documnetation tweaks; added Q loss equations and light explanation #145

Merged
merged 1 commit into from
Mar 23, 2022

Conversation

dosssman
Copy link
Collaborator

@dosssman dosssman commented Mar 23, 2022

Description

  • Fixed a few typos and proposed some reformulations of a few sentences.
  • Added a little bit more details regarding DDPG's Q loss.

Other comments

  • Regarding the hard time reproducing ddpg on Mujoco-v1, I was wondering how feasible it would be to run fujimoto's DDPG.py etc.. on free-mujoco

Other than that, great job on the pretty complete documentation for DDPG @vwxyzjn @yooceii , and sorry for being late to the party 🙇

Types of changes

  • Bug fix
  • New feature
  • New algorithm
  • Documentation

Checklist:

  • I've read the CONTRIBUTION guide (required).
  • I have ensured pre-commit run --all-files passes (required).
  • I have updated the documentation and previewed the changes via mkdocs serve.
  • I have updated the tests accordingly (if applicable).

If you are adding new algorithms or your change could result in performance difference, you may need to (re-)run tracked experiments. See #137 as an example PR.

  • I have contacted @vwxyzjn to obtain access to the openrlbenchmark W&B team (required).
  • I have tracked applicable experiments in openrlbenchmark/cleanrl with --capture-video flag toggled on (required).
  • I have added additional documentation and previewed the changes via mkdocs serve.
    • I have explained note-worthy implementation details.
    • I have explained the logged metrics.
    • I have added links to the original paper and related papers (if applicable).
    • I have added links to the PR related to the algorithm.
    • I have created a table comparing my results against those from reputable sources (i.e., the original paper or other reference implementation).
    • I have added the learning curves (in PNG format with width=500 and height=300).
    • I have added links to the tracked experiments.
  • I have updated the tests accordingly (if applicable).

@vercel
Copy link

vercel bot commented Mar 23, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/vwxyzjn/cleanrl/CSE1uakxpjPwtLa1Dm9cmjwxxE4g
✅ Preview: https://cleanrl-git-fork-dosssman-ddpg-docs-tweaks-vwxyzjn.vercel.app

@gitpod-io
Copy link

gitpod-io bot commented Mar 23, 2022

@dosssman dosssman requested a review from vwxyzjn March 23, 2022 02:40
@vwxyzjn
Copy link
Owner

vwxyzjn commented Mar 23, 2022

This PR is a follow-up on #137. Thanks @dosssman for this fix! I will take a look at it tomorrow :)

Regarding the hard time reproducing ddpg on Mujoco-v1, I was wondering how feasible it would be to run fujimoto's DDPG.py etc.. on free-mujoco

There it is: https://wandb.ai/openrlbenchmark/openrlbenchmark/reports/MuJoCo-sfujim-TD3--VmlldzoxNzIyODIz

@dosssman
Copy link
Collaborator Author

Thanks. The report seems privated though:

image

@vwxyzjn
Copy link
Owner

vwxyzjn commented Mar 23, 2022

Could you try it again?

@dosssman
Copy link
Collaborator Author

All good now

Copy link
Owner

@vwxyzjn vwxyzjn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@vwxyzjn vwxyzjn merged commit cfed3dd into vwxyzjn:master Mar 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants