Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add e2e tests #70

Merged
merged 10 commits into from
Oct 27, 2021
Merged

Add e2e tests #70

merged 10 commits into from
Oct 27, 2021

Conversation

vwxyzjn
Copy link
Owner

@vwxyzjn vwxyzjn commented Oct 22, 2021

This PR adds end-to-end tests to make sure the CleanRL scripts run without errors. The test case is basically running

subprocess.run("python cleanrl/ppo.py --total-timesteps 1000", shell=True, check=True)

[ ] only trigger the run when changes to the source code happen.

cleanrl/ddpg_continuous_action.py Outdated Show resolved Hide resolved
cleanrl/sac_continuous_action.py Outdated Show resolved Hide resolved
cleanrl/td3_continuous_action.py Outdated Show resolved Hide resolved
tests/test_atari.py Show resolved Hide resolved

def test_ppo():
subprocess.run(
"python cleanrl/ppo.py --num-envs 1 --num-steps 64 --total-timesteps 256",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same above

tests/test_pybullet.py Show resolved Hide resolved
@vwxyzjn vwxyzjn merged commit 87d4e87 into master Oct 27, 2021
@vwxyzjn vwxyzjn deleted the e2e-test branch October 27, 2021 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants