Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CI for python3.8-dev #38

Merged
merged 1 commit into from Oct 25, 2018
Merged

Fix CI for python3.8-dev #38

merged 1 commit into from Oct 25, 2018

Conversation

vxgmichel
Copy link
Owner

@vxgmichel
Copy link
Owner Author

Hi @RyanWangGit, any comment about this PR?

I can add you as a collaborator if you wish to make a more formal review :)

@yuxincs
Copy link
Contributor

yuxincs commented Oct 25, 2018 •
edited by vxgmichel

Nice hack! LGTM, hopefully they can fix this issue shortly. I think you can merge this and close #36 now 👍

@vxgmichel vxgmichel merged commit 847fadd into master Oct 25, 2018
@vxgmichel vxgmichel deleted the issue-36 branch October 25, 2018 15:55
@vxgmichel
Copy link
Owner Author

Merged, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vxgmichel @yuxincs