Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed deprecation warning for importing ABC's from collections #27

Merged
merged 1 commit into from Sep 13, 2018

Conversation

timworx
Copy link
Contributor

@timworx timworx commented Sep 13, 2018

Fixed deprecation warnings popping up in 3.7

DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated, and in 3.8 it will stop working

Tested and passing in 3.6.2 & 3.7.0

Side note: Current tests fail in 3.6.0, seems to be a sqlite error of some sort.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 186f662 on timworx:update-collections-import into 755ee18 on vxgmichel:master.

@vxgmichel vxgmichel merged commit 33b2233 into vxgmichel:master Sep 13, 2018
@vxgmichel
Copy link
Owner

Hi @timworx, thanks for the PR!

Side note: Current tests fail in 3.6.0, seems to be a sqlite error of some sort.

I tried to reproduce this issue and I did get some weird internal errors from coverage, although the tests are actually passing in my environment. I think I'll ignore it for the moment.

@timworx
Copy link
Contributor Author

timworx commented Sep 13, 2018

Interesting, might be something to do with my env then (either way, it didn't seem like a terribly important bug).

If it is somehow env related then adding a Pipfile might help.

@timworx
Copy link
Contributor Author

timworx commented Sep 13, 2018

And thanks for the merge! 👍

@timworx timworx deleted the update-collections-import branch September 13, 2018 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants