fix corrupted json generator state after exception #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vy
reviewed
Apr 19, 2019
| generator.writeEndArray(); | ||
| } else if (ctx.inObject()) { | ||
| generator.writeEndObject(); | ||
| } else { |
There was a problem hiding this comment.
I think resetGeneratorState has a short-coming which has already been addressed in rescueJsonGeneratorState. Consider the following:
JsonGenerator jsonGenerator = objectMapper.getFactory().createGenerator(outputStream);
jsonGenerator.writeStartObject();
jsonGenerator.writeFieldName("foo");At this state, neither a ], nor a } would suffice; a jsonGenerator.writeFieldValue(someRandomValue) is required. I am working on top of your changes to make this work, FYI.
vy
added a commit
that referenced
this pull request
Apr 21, 2019
…and instantiate a new one. Given[1] there is no proper way to recover from a corrupted JsonGenerator state, rather than waiting for the next bug report of this hack, I just ditched it off. [1] https://groups.google.com/d/msg/jackson-user/vsJST_drx04/rFSF5jSyBQAJ
|
@bakomchik (@labakomchev?), see the 3addd31 fix I have just pushed. Would you mind testing and reporting back if this fixes the issue, please? BTW, I have already added your "nickname" and GitHub account to the list of contributors. Do you a certain name rather than "bakomchik"? |
|
Merged the changes to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix bug with stack overflow error
demonstrated here
bakomchik@f933ba0