Change the size of Youtube video #8
Comments
|
hi Daniel, i’m actively working on supporting the new |
- feat: add keyboard shortcuts to 1) play/pause and 2) skip forward/backward timestamp for youtube and local videos - feat: increasing the width of videos no longer shows the overflow scroll bar (addresses #5) - feat: local videos can be resized (addresses #8) - refactor: update `startFloat(e)` to support the new `{{video URL}}` macro in Logseq version 0.7.0+ (addresses #7)
- feat: add keyboard shortcuts to 1) play/pause and 2) skip forward/backward timestamp for youtube and local videos - feat: increasing the width of videos no longer shows the overflow scroll bar (addresses #5) - feat: local videos can be resized (addresses #7) - refactor: update `startFloat(e)` to support the new `{{video URL}}` macro in Logseq version 0.7.0+ (addresses #8)
|
added in v.2.0.0! let me know if you run into any issues |
|
Thanks! It works for youtube video now, but it doesn't work for the local video, even the start float function is not compatiable with the local video. Can you fix this? Thanks! |
|
can you share your local video syntax? the one i currently have supported is |
|
[:video {:controls true :src "path"}] |
|
gotcha, i haven't seen this syntax before - i'll work on supporting it |
|
Thanks, how can l use your syntax, since mine is from the logseq directly? If l wan to use your syntax by using "/..."how can l do that ? Can you have a look at it ,thanks! |
|
l have tried your syntax and the video still can't be shown. |
- fixed: support all syntax for embedding local videos (addresses #8)
|
can you update to v.2.0.1 and try again using your original syntax? |
|
Sure! |
|
It seems that you haven't updated the 2.0.1 release. It is still 2.0.0 in both you Github release and in the marketplace. @vyleung |
|
oops - i pushed the commit, but forgot to create a release 😅 please check again |
|
Thanks , it works now , but it seems that there is a bug with this button. |
- fixed: clicking on local videos show incorrect play/pause icon [created `playPauseControls_Listener()` instead of using `playPauseControls()`] (addresses #8)
|
hopefully v.2.0.2 fixes this issue |
|
ok 😂 l am trying it now. |
|
Thanks , this bug is fixed now , but l think l have found a new one. If l play the video first and then |
- fixed: playing a video then activating the plugin shows incorrect icon (addresses #8)
|
try v.2.0.3 - thanks for finding all these bugs btw! |
|
It works perfectly now! Thanks for fixing all the bugs 😄. BTW, hope the translation function can be added soon! |
l use Logseq 0.7.0 now and l find that l can't change the size of Youtube video.
Here is the youtube video link:https://www.youtube.com/watch?v=6Af6b_wyiwI
Here is my code to use it in the Logseq
{{video https://www.youtube.com/watch?v=6Af6b_wyiwI}}l hope the plugin can be updated to suit the latest version of Logseq. Thanks!
Daniel
The text was updated successfully, but these errors were encountered: