Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T6316: added pr templates and codeowner file #1

Merged
merged 5 commits into from
May 10, 2024
Merged

Conversation

kumvijaya
Copy link
Contributor

No description provided.

@c-po
Copy link
Member

c-po commented May 9, 2024

@kumvijaya very interesting PR, does it mean one can have a .github repository which keeps templates and actions which are used in all repos under the organisation?

@kumvijaya
Copy link
Contributor Author

@kumvijaya very interesting PR, does it mean one can have a .github repository which keeps templates and actions which are used in all repos under the organisation?

@c-po .github repo will be used to keep codeowner file and templates,
The workflows will be kept in vyos-github-actions repository.

Copy link
Member

@andamasov andamasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For codeowners it seems synthax should be different
I see error
Unknown owner on line 1: make sure the team @vyos/reviewers exists, is publicly visible, and has write access to the repository

  • @vyos/reviewers

@kumvijaya
Copy link
Contributor Author

kumvijaya commented May 9, 2024

For codeowners it seems synthax should be different I see error Unknown owner on line 1: make sure the team @vyos/reviewers exists, is publicly visible, and has write access to the repository

  • @vyos/reviewers

@andamasov
ok
Copilot also says-

The team must have write access to the repository. You can check this in the repository's settings under the "Manage access" section.

So, I have added vyos/reviewers to this repository with write access.
Hope this is ok.
Please confirm.

@kumvijaya kumvijaya requested a review from andamasov May 10, 2024 10:16
Copy link
Member

@andamasov andamasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no error anymore

@kumvijaya kumvijaya requested a review from andamasov May 10, 2024 11:54
@kumvijaya
Copy link
Contributor Author

Please approve and merge if all ok. Thanks

.github/workflows/pull-request-labels.yml Outdated Show resolved Hide resolved
.github/workflows/pull-request-management.yml Outdated Show resolved Hide resolved
.github/workflows/pull-request-message-check.yml Outdated Show resolved Hide resolved
.github/workflows/unused-imports.yml Outdated Show resolved Hide resolved
@c-po c-po merged commit 1e62015 into main May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants