Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

traffic-policy: T4688: add support for limiter exceed/notexceed actions #19

Closed
wants to merge 1 commit into from

Conversation

initramfs
Copy link

Change Summary

This is a forward port of #18 to the current branch.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Component(s) name

traffic-policy

Proposed changes

See #18

How to test

See #18

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

@c-po
Copy link
Member

c-po commented Oct 10, 2022

Hi @initramfs,

I wonder if we can put this one on hold and not extend the old Perl code anymore. I am trying my best to get the new QoS python based implementation (https://github.com/c-po/vyos-1x/tree/t4284-qos) into current.

So I'd rather pick up vyos/vyos-1x#1547 to the new implementation and let the old one rest.

Would this be ok for you or is this an urgent need? This would also be in line with the "No new features in the old codebase" approach.

@c-po c-po assigned c-po and initramfs and unassigned c-po Oct 10, 2022
@initramfs
Copy link
Author

@c-po Yeah that's no problem, I added this feature for personal use anyway and it can easily be scripted in (I made this PR merely to convert more scripting elements into config).

@initramfs initramfs closed this Oct 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants