Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T5247: T2556: Delete deprecated commans show interfaces system and vrrp #86

Merged
merged 1 commit into from Jan 15, 2024

Conversation

sever-sever
Copy link
Member

Change Summary

Delete deprecated op-mode comamnds:

  • show interfaces system
  • show interfaces vrrp
vyos@r4:~$ show interfaces system
-vbash: /opt/vyatta/bin/vyatta-show-interfaces: No such file or directory

For VRRP we use show vrrp

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe): Delete deprecated/old commands

Related Task(s)

Related PR(s)

Component(s) name

interfaces

Proposed changes

How to test

Before delete

vyos@r4:~$ show interfaces system 
-vbash: /opt/vyatta/bin/vyatta-show-interfaces: No such file or directory
vyos@r4:~$ 
vyos@r4:~$ show interfaces system 
-vbash: /opt/vyatta/bin/vyatta-show-interfaces: No such file or directory
vyos@r4:~$ 
vyos@r4:~$ show interfaces vrrp 
Codes: S - State, L - Link, u - Up, D - Down, A - Admin Down
Interface        IP Address                        S/L  Description
---------        ----------                        ---  -----------
vyos@r4:~$ 

Smoketest result

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

Delete deprecated op-mode comamnds:
 - show interfaces system
 - show interfaces vrrp

```
vyos@r4:~$ show interfaces system
-vbash: /opt/vyatta/bin/vyatta-show-interfaces: No such file or directory

```

For VRRP we use `show vrrp`
@sever-sever sever-sever requested review from a team, dmbaturin, sarthurdev, zdc, jestabro and c-po and removed request for a team January 14, 2024 23:26
@vyosbot vyosbot requested a review from a team January 14, 2024 23:26
@c-po c-po merged commit b83935b into vyos:current Jan 15, 2024
6 of 8 checks passed
@sever-sever
Copy link
Member Author

@Mergifyio backport sagitta

Copy link

mergify bot commented Jan 15, 2024

backport sagitta

✅ Backports have been created

c-po added a commit that referenced this pull request Jan 15, 2024
T5247: T2556: Delete deprecated commans show interfaces system and vrrp (backport #86)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2 participants