webproxy: T3671: Fix paths from squid3 to squid

[sever-sever]

In the original pkg squid a paths was changed from squid3 to squid.
This fixes changing all mentioned squid3 to squid.
https://phabricator.vyos.net/T3671

Webproxy in 1.2.8 can't start without this change

Tested configuration

set service webproxy listen-address 0.0.0.0 disable-transparent

Check processes

vyos@r12-lts:~$ 
vyos@r12-lts:~$ sudo netstat -tulpn | grep squid
tcp        0      0 0.0.0.0:3128            0.0.0.0:*               LISTEN      1702/(squid-1)  
udp        0      0 0.0.0.0:57481           0.0.0.0:*                           1702/(squid-1)  
udp6       0      0 :::42825                :::*                                1702/(squid-1)  
vyos@r12-lts:~$ 

[dmbaturin]

My only immediate objection is that we should be using systemctl for restarting services, not legacy SysV init scripts.

There are also quite a few mentions of the long-gone "vyattaguard". But I think there are more, so we should probably make a separate task for it.

Also, the amount of duplicated code makes me wonder if we should consolidate clear and restart scripts into a single script.

[dmbaturin]

VyattaGuard was a squidguard version with proprietary rules, as far as I remember. In any case it's no longer relevant.

[sever-sever]

I delete it.

[sever-sever]

The initial configuration works fine. Also after reboot, the service works.

set service webproxy listen-address 0.0.0.0 disable-transparent

I found some problem when we re-add configuration for webproxy, I can't commit it.

vyos@r12-lts# delete service webproxy 
[edit]
vyos@r12-lts# commit
[edit]
vyos@r12-lts#
vyos@r12-lts# set service webproxy listen-address 0.0.0.0 disable-transparent 
[edit]
vyos@r12-lts# commit

This commit hangs forever.

vyos@r12-lts:~$ ps ax | grep commit | egrep -v grep
 2453 pts/0    S+     0:00 /opt/vyatta/sbin/my_commit
vyos@r12-lts:~$ 

A similar bug was described in https://phabricator.vyos.net/T1770

Update. The reason for the commit hangs it trying to update squidguard db, but it is not configured.
https://github.com/vyos/vyatta-webproxy/blob/360343120ebcf50737f6914aac5c3efbad771ca9/scripts/vyatta-update-webproxy.pl#L1193
So it hangs on

vyos@r12-lts:~$ sudo -u proxy squidGuard -C all
We trust you have received the usual lecture from the local System
Administrator. It usually boils down to these three things:
    #1) Respect the privacy of others.
    #2) Think before you type.
    #3) With great power comes great responsibility.
[sudo] password for vyos: