Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

interface: T4056: Fix unexpected delete tc qdisc #1117

Merged
merged 1 commit into from Dec 21, 2021
Merged

interface: T4056: Fix unexpected delete tc qdisc #1117

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions python/vyos/ifconfig/interface.py
View file
Open in desktop
Expand Up @@ -1304,8 +1304,8 @@ def set_mirror(self):
source_if = next(iter(self._config['is_mirror_intf']))
config = self._config['is_mirror_intf'][source_if].get('mirror', None)

# Check configuration stored by old perl code before delete T3782
if not 'redirect' in self._config:
# Check configuration stored by old perl code before delete T3782/T4056
if not 'redirect' in self._config and not 'traffic_policy' in self._config:
# Please do not clear the 'set $? = 0 '. It's meant to force a return of 0
# Remove existing mirroring rules
delete_tc_cmd = f'tc qdisc del dev {source_if} handle ffff: ingress 2> /dev/null;'
Expand Down