Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keepalived: T4526: keepalived-fifo.py unable to load config #1485

Closed
wants to merge 1 commit into from

Conversation

roedie
Copy link
Contributor

@roedie roedie commented Aug 22, 2022

Change Summary

keepalived-fifo.py cannot load the VyOS config because the
script is started before the commit i completely finished.

This change makes sure the script tries to load the config
every 0.5 seconds for 10 times.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Component(s) name

keepalived

Proposed changes

How to test

I've tested this by replacing the script with my own version and configuring keepalived.

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

keepalived-fifo.py cannot load the VyOS config because the
script is started before the commit i completely finished.

This change makes sure the script tries to load the config
every 0.5 seconds for 10 times.
@sarthurdev
Copy link
Member

I'd suggest instead looping on vyos.util.commit_in_progress to ensure the commit in progress is completed.

@roedie
Copy link
Contributor Author

roedie commented Aug 22, 2022

Ah, I'll create a new pull request then.

@roedie roedie closed this Aug 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants