Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

radius: T4672: Fix RADIUS server disable template logic #1523

Merged
merged 1 commit into from Sep 7, 2022

Conversation

bmhughes
Copy link
Contributor

@bmhughes bmhughes commented Sep 6, 2022

Change Summary

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Component(s) name

RADIUS

Proposed changes

Change the jinja template to check for the presence of the disable dict key (rather than looking for a disabled property that doesn't exist)

How to test

Disable a RADIUS server, it will now be removed from the config file.

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

@c-po c-po merged commit f947cf1 into vyos:current Sep 7, 2022
@bmhughes bmhughes deleted the fix-radius-disable branch September 8, 2022 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants