Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bridge: T4673: raise UnconfiguredSubsystem on non-existent bridge intf #1524

Merged
merged 1 commit into from Sep 6, 2022

Conversation

jestabro
Copy link
Contributor

@jestabro jestabro commented Sep 6, 2022

Change Summary

In the case of non-existent bridge interface, the command, called by _get_raw_data_fdb:

sudo bridge --json fdb show br {bridge}

will return exit code -1. The source code for iproute2 'show_fdb' reveals that this is the only condition to return -1 for that command, consequently we can unambiguously raise the op-mode error 'UnconfiguredSubsystem' in this case.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Component(s) name

Proposed changes

How to test

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

@jestabro jestabro self-assigned this Sep 6, 2022
@jestabro jestabro merged commit acd3a42 into vyos:current Sep 6, 2022
@jestabro jestabro deleted the bridge-op-mode branch November 21, 2022 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants