Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

route: T4772: return list of dicts in 'raw' output #1614

Merged
merged 1 commit into from Oct 24, 2022

Conversation

jestabro
Copy link
Contributor

Change Summary

The consensus is that a list of dicts is preferable as the output of route.py in the 'raw' case, instead of a dict indexed by prefix. As prefix is already contained in the dict values, it is redundant information, and the default dict output format makes processing less convenient for the local-ui.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Output formatting.

Related Task(s)

Component(s) name

Proposed changes

How to test

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

@jestabro jestabro self-assigned this Oct 24, 2022
@jestabro jestabro merged commit ec82d60 into vyos:current Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants