http-api: T5006: add explicit async to retrieve/configure methods for REST #1823
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
The REST endpoints 'retrieve' and 'configure' can reveal a segfault under concurrent connections unless methods are defined explicitly as 'async'. Add async modifier to methods.
This affects only Sagitta REST requests; the segfault will occur in the underlying libc, in vyatta-cfg, respectively, libvyosconfig. Equuleus is not affected, nor are GraphQL requests.
Note that the underlying web framework for the http-api, FastAPI, automatically takes care of red/blue function issues, 'usually'; here is a case where we must be explicit.
Types of changes
Related Task(s)
Component(s) name
Proposed changes
How to test
Thanks to the user who opened the bug report, testing may be done with:
respectively
for suitable 'host-name'.
Checklist: