Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xml: T5179: fix missed case in multi_to_list conversion #1970

Merged
merged 1 commit into from Apr 25, 2023

Conversation

jestabro
Copy link
Contributor

@jestabro jestabro commented Apr 25, 2023

Change Summary

The fix for multi_to_list in T3234 only handled the case of multiple XML elements in an interface-definition file sharing a single name at the same level; extend for the case of multiple sub-elements sharing a path of length > 1 at the same level, for example, after merging include files:

protocols-bgp.xml

will contain two instances of path ["address-family", "l2vpn-evpn"] under ["protocols", "bgp"].

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Component(s) name

Proposed changes

How to test

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

@jestabro jestabro self-assigned this Apr 25, 2023
@vyosbot vyosbot requested review from a team, dmbaturin, sarthurdev, zdc, sever-sever and c-po and removed request for a team April 25, 2023 05:55
Copy link
Member

@dmbaturin dmbaturin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My only objection is too many S's in "misssed". :)

@jestabro jestabro changed the title xml: T5178: fix misssed case in multi_to_list conversion xml: T5178: fix missed case in multi_to_list conversion Apr 25, 2023
@jestabro
Copy link
Contributor Author

Oops, yes; thanks !

@jestabro jestabro changed the title xml: T5178: fix missed case in multi_to_list conversion xml: T5179: fix missed case in multi_to_list conversion Apr 25, 2023
@c-po c-po merged commit 28429f6 into vyos:current Apr 25, 2023
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants