cloud-init: T5190: Added Cloud-init pre-configurator #1978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a new service that starts before Cloud-init, waits for all network interfaces initialization, and if requested by config, checks which interfaces can get configuration via DHCP server and creates a corresponding Cloud-init network configuration. This protects from two situations: * when Cloud-init tries to get meta-data via eth0 (default and fallback variant for any data source which depends on network), but the real network is connected to another interface * when Cloud-init starts simultaneously with udev and initializes the first interface to get meta-data before it is renamed to eth0 by udev
vyosbot
requested review from
a team,
dmbaturin,
sarthurdev,
jestabro,
sever-sever and
c-po
and removed request for
a team
sever-sever
approved these changes
May 5, 2023
c-po
reviewed
May 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Added Cloud-init pre-configurator
Types of changes
Related Task(s)
Component(s) name
cloud-init
Proposed changes
Added a new service that starts before Cloud-init, waits for all network interfaces initialization, and if requested by config, checks which interfaces can get configuration via DHCP server and creates a corresponding Cloud-init network configuration.
This protects from two situations:
How to test
To test this, you need to deploy VyOS in an environment with Cloud-init, where meta-data should be fetched from the network and connect the VM to the network via any interface, except
eth0. A good test environment is Equinix Metal, where usuallyeth2is the main interface.Without this change, the system will fail to get any meta-data and possibly will have an
e0interface excepteth0.Checklist: