Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T5253: commit priority: commit error received when mpls config executed with WG #2032

Merged
merged 1 commit into from Jun 7, 2023

Conversation

srividya0208
Copy link
Contributor

Change Summary

MPLS configuration part when included with a wireguard interface is executed for first time(adding the interface config in the same commit), an error is received because of the priority preference. Rebooting the device removes the mpls configuration. Increased the priority of the wireguard node compared to mpls.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Component(s) name

wireguard

Proposed changes

Existing code:

  <tagNode name="wireguard" owner="${vyos_conf_scripts_dir}/interfaces-wireguard.py">
    <properties>
      <help>WireGuard Interface</help>
      <priority>459</priority>
      <constraint>

New change:

  <tagNode name="wireguard" owner="${vyos_conf_scripts_dir}/interfaces-wireguard.py">
    <properties>
      <help>WireGuard Interface</help>
      <priority>381</priority>
      <constraint>

How to test

set interfaces wireguard wg0 address '100.120.0.2/30'
set interfaces wireguard wg0 peer PE2 address '192.168.11.1'
set interfaces wireguard wg0 peer PE2 allowed-ips '0.0.0.0/0'
set interfaces wireguard wg0 peer PE2 port '51820'
set interfaces wireguard wg0 peer PE2 public-key <key>
set interfaces wireguard wg0 port '51820'
set interfaces wireguard wg0 private-key <key>
set protocols mpls interface 'wg0'
set protocols mpls ldp interface 'wg0'

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

@vyosbot vyosbot requested review from a team, dmbaturin, sarthurdev and zdc and removed request for a team June 7, 2023 12:03
@c-po c-po merged commit eab7e3a into vyos:current Jun 7, 2023
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants