Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T5329 : priority: tunnel config is committed before wireguard #2063

Merged
merged 1 commit into from Jun 30, 2023

Conversation

srividya0208
Copy link
Contributor

Change Summary

Having a wireguard interface as the source interface on a GRE tunnel causes a configuration error on boot. Wireguard is not yet exists in the system when tun is already exists due to priority, that's why error is received

vyos@vyos:~$ /opt/vyatta/sbin/priority.pl | match "tun|wireguard"
380 interfaces/tunnel
381 interfaces/wireguard

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Component(s) name

wireguard

Proposed changes

  <tagNode name="wireguard" owner="${vyos_conf_scripts_dir}/interfaces-wireguard.py">
    <properties>
      <help>WireGuard Interface</help>
      <priority>379</priority>
      <constraint>

How to test

Configuration:

set interfaces tunnel tun0 address '10.68.1.17/30'
set interfaces tunnel tun0 encapsulation 'gre'
set interfaces tunnel tun0 remote '10.68.0.2'
set interfaces tunnel tun0 source-address '10.68.0.9'
set interfaces tunnel tun0 source-interface 'wg0'
set interfaces wireguard wg0 address '20.68.0.9/30'
set interfaces wireguard wg0 peer FR address '192.168.11.1'
set interfaces wireguard wg0 peer FR allowed-ips '0.0.0.0/0'
set interfaces wireguard wg0 peer FR port '51820'
set interfaces wireguard wg0 peer FR public-key 'gbse3gHYt90wDXoGCUClbwKf3DWFVPpSNEebI8RkIhg='
set interfaces wireguard wg0 private-key 'enfaVowlSURdQqvRDNjFrztz1+cUTlQXHQSDTl9OGDs='

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

@vyosbot vyosbot requested review from a team, dmbaturin, sarthurdev, zdc, jestabro, sever-sever and c-po and removed request for a team June 30, 2023 18:25
@dmbaturin dmbaturin merged commit 881eee5 into vyos:current Jun 30, 2023
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants