static: T5398: do not mangle interface names in FRR #2110
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
This PR resolves an issue when configuring static routes involving interfaces containing a
-
in the name. When rendered to FRR, the interface is mangled to an underscore_
. This is most noticeable when creating static VRF-leaked routes for container networks:pod-TEST
becomespod_TEST
No static route is installed into the table due to the mismatching interface name:
Types of changes
Related Task(s)
Component(s) name
Proposed changes
Update the static configuration retrieval in
protocols_static.py
to not mangle node values by adding theno_tag_node_value_mangle=True
option.How to test
Perform the configuration changes as documented in the change summary. However after this change is applied and
vyos-configd
is restarted the interface name is no longer mangled:The route is also installed into the routing table:
Checklist: