Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T5319: remove workarounds for defaults in high-availability.py #2131

Merged
merged 1 commit into from Aug 2, 2023

Conversation

jestabro
Copy link
Contributor

@jestabro jestabro commented Aug 2, 2023

Change Summary

Convert conf_mode script high-availability.py to use automatic defaults. This change is PR'd separately as it also resolves the problem in T5350 (Confusing warning message when committing VRRP config) and is the example mentioned in the discussion of defaults and invariants in

#2010

TLDR: the revision uses the option with_defaults to get_config_dict to merge only defaults of leaf nodes with a parent in the config; this avoids the spurious warning in T5350 and the need to manually trim garp settings if not set by user.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):
    Update to avoid workarounds.

Related Task(s)

Component(s) name

vrrp

Proposed changes

How to test

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

@jestabro jestabro self-assigned this Aug 2, 2023
@vyosbot vyosbot requested review from a team, dmbaturin, sarthurdev, zdc, sever-sever and c-po and removed request for a team August 2, 2023 18:17
@jestabro jestabro changed the title T5319: remove workarounds for incorrect defaults T5319: remove workarounds for defaults in high-availability.py Aug 2, 2023
@c-po c-po merged commit 0fb28c9 into vyos:current Aug 2, 2023
5 of 6 checks passed
@jestabro jestabro deleted the high-availability-defaults branch August 2, 2023 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants