T5319: remove workarounds for defaults in high-availability.py #2131
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Convert conf_mode script
high-availability.py
to use automatic defaults. This change is PR'd separately as it also resolves the problem in T5350 (Confusing warning message when committing VRRP config) and is the example mentioned in the discussion of defaults and invariants in#2010
TLDR: the revision uses the option
with_defaults
toget_config_dict
to merge only defaults of leaf nodes with a parent in the config; this avoids the spurious warning in T5350 and the need to manually trim garp settings if not set by user.Types of changes
Update to avoid workarounds.
Related Task(s)
Component(s) name
vrrp
Proposed changes
How to test
Checklist: