Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dhcp(v6): T5428: client renewal fails when running inside VRF (equuleus backport) #2134

Closed
wants to merge 2 commits into from
Closed

dhcp(v6): T5428: client renewal fails when running inside VRF (equuleus backport) #2134

wants to merge 2 commits into from

Conversation

c-po
Copy link
Member

@c-po c-po commented Aug 5, 2023

Change Summary

Backport bugfixes from 1.4 to start DHCP clients in given VRF

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Component(s) name

  • IPv4/IPv6 DHCP client

Proposed changes

Start daemons in appropriate VRF

How to test

Smoketests or

set interfaces ethernet eth1 address dhcp
set interfaces ethernet eth1 address dhcpv6
set interfaces ethernet eth1 ipv6 address autoconf
set vrf name red table '1000'

vyos@vyos:~$  show vrf red processes
 7120  dhcp6c
 7071  dhclient

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

@c-po
dhcp: T5428: client renewal fails when running inside VRF
11cbf94 
vyos@vyos# run show vrf MGMT processes
 2282  sshd

There is no dhclient process running in given VRF. dhclient complains it can
not send out packets via the given interface (as it's not bound to that VRF)

Aug 02 20:29:54 dhclient[1686]: send_packet: Network is unreachable
Aug 02 20:29:54 dhclient[1686]: send_packet: please consult README file regarding broadcast address.
Aug 02 20:29:54 dhclient[1686]: dhclient.c:3001: Failed to send 300 byte long packet over fallback interface.

(cherry picked from commit 782e400)
@c-po
dhcpv6: T5428: client renewal fails when running inside VRF
90e9201 
(cherry picked from commit 8a15595)
@vyosbot vyosbot requested review from a team, dmbaturin, sarthurdev, zdc, jestabro and sever-sever and removed request for a team August 5, 2023 20:52
@c-po c-po changed the title Vrf dhcp fixes dhcp(v6): T5428: client renewal fails when running inside VRF (equuleus backport) Aug 5, 2023
@c-po
Copy link
Member Author

c-po commented Aug 8, 2023

Closing this as there is another issue when moving dhclient arround VRFs. PR will be resubmitted.

@c-po c-po closed this Aug 8, 2023
@c-po c-po deleted the vrf-dhcp-fixes branch November 27, 2023 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmbaturin dmbaturin Awaiting requested review from dmbaturin dmbaturin was automatically assigned from vyos/reviewers

@sarthurdev sarthurdev Awaiting requested review from sarthurdev sarthurdev was automatically assigned from vyos/reviewers

@zdc zdc Awaiting requested review from zdc zdc was automatically assigned from vyos/reviewers

@jestabro jestabro Awaiting requested review from jestabro jestabro was automatically assigned from vyos/reviewers

@sever-sever sever-sever Awaiting requested review from sever-sever sever-sever was automatically assigned from vyos/reviewers

Assignees

@c-po c-po

Labels
None yet
Milestone
No milestone
1 participant
@c-po