Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T5319: remove workarounds for incorrect defaults in config-mode scripts #2136

Merged
merged 55 commits into from Aug 9, 2023

Conversation

jestabro
Copy link
Contributor

@jestabro jestabro commented Aug 7, 2023

Change Summary

This updates all conf_mode scripts to remove the workarounds for incorrect defaults, and replace any other calls of defaults with reliable patterns of merging default values in the config_dict.

Note this was tested without commit 710dac5, pending a fix for the revised smoketests, although it has been rebased over current as is.

In the course of converting conf_mode scripts, another pattern for merging defaults was introduced in T5443, as intermediary between the coarse-grained control of automatic merging of defaults in get_config_dict and the fine-grained control of get_config_defaults/config_dict_merge; the available patterns are summarized in that task, and examples of each are in the conf_mode script translations. That method is included in this PR.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Component(s) name

Proposed changes

How to test

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

@jestabro jestabro self-assigned this Aug 7, 2023
@vyosbot vyosbot requested review from a team, dmbaturin, sarthurdev, zdc, sever-sever and c-po and removed request for a team August 7, 2023 07:11
@c-po c-po merged commit 98ed11a into vyos:current Aug 9, 2023
5 of 6 checks passed
@jestabro jestabro deleted the with-defaults branch September 1, 2023 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants