New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
T5319: remove workarounds for incorrect defaults in config-mode scripts #2136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Drop low-level merge_defaults function in favor of Config method for a middle-grained level of control when merging defaults.
vyosbot
requested review from
a team,
dmbaturin,
sarthurdev,
zdc,
sever-sever and
c-po
and removed request for
a team
August 7, 2023 07:11
c-po
approved these changes
Aug 8, 2023
sever-sever
approved these changes
Aug 8, 2023
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
This updates all conf_mode scripts to remove the workarounds for incorrect defaults, and replace any other calls of
defaults
with reliable patterns of merging default values in the config_dict.Note this was tested without commit 710dac5, pending a fix for the revised smoketests, although it has been rebased over current as is.
In the course of converting conf_mode scripts, another pattern for merging defaults was introduced in T5443, as intermediary between the coarse-grained control of automatic merging of defaults in
get_config_dict
and the fine-grained control ofget_config_defaults/config_dict_merge
; the available patterns are summarized in that task, and examples of each are in the conf_mode script translations. That method is included in this PR.Types of changes
Related Task(s)
Component(s) name
Proposed changes
How to test
Checklist: