Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T5700: Fix deprecate telegraf plugin input net #2425

Merged
merged 1 commit into from Nov 2, 2023

Conversation

sever-sever
Copy link
Member

Change Summary

Fix deprecate telegraf plugin input net

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe): Fix deprecated plugin input.net

Related Task(s)

Related PR(s)

Component(s) name

telegraf

Proposed changes

How to test

set service monitoring telegraf prometheus-client

Before the fix:

Nov 02 12:10:11 r4 telegraf[4017]: 2023-11-02T10:10:11Z I! [agent] Config: Interval:15s, Quiet:false, Hostname:"r4", Flush Interval:15s
Nov 02 12:10:11 r4 telegraf[4017]: 2023-11-02T10:10:11Z W! DeprecationWarning: Value "false" for option "ignore_protocol_stats" of plugin "inputs.net" deprecated since version 1.27.3 and will be removed in 1.36.0: use the 'inputs.nstat' plugin instead


Smoketest result

vyos@r4:~$ /usr/libexec/vyos/tests/smoke/cli/test_service_monitoring_telegraf.py
test_01_basic_config (__main__.TestMonitoringTelegraf.test_01_basic_config) ... ok

----------------------------------------------------------------------
Ran 1 test in 4.410s

OK

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

DeprecationWarning: Value "false" for option "ignore_protocol_stats"
of plugin "inputs.net" deprecated since version 1.27.3 and will be
removed in 1.36.0: use the 'inputs.nstat' plugin instead
@vyosbot vyosbot requested review from a team, dmbaturin, sarthurdev, zdc, jestabro and c-po and removed request for a team November 2, 2023 13:12
@sever-sever sever-sever merged commit 42d4a2d into vyos:current Nov 2, 2023
8 checks passed
@sever-sever
Copy link
Member Author

@Mergifyio backport sagitta

Copy link

mergify bot commented Nov 2, 2023

backport sagitta

✅ Backports have been created

sever-sever added a commit that referenced this pull request Nov 2, 2023
T5700: Fix deprecate telegraf plugin input net (backport #2425)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2 participants