mtr: T5658: Add VRF support for mtr (+ op_mode wrapper)

[bbabich]

Change Summary

• Adds op_mode wrapper for mtr and all the good things that come along with it (like VRF support).
• Re-introduces 'monitor traceroute' as requested by @c-po

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Code style update (formatting, renaming)
• Refactoring (no functional changes)
• Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
• Other (please describe):

Related Task(s)

• https://vyos.dev/T5658

Component(s) name

• mtr
• monitor traceroute

Proposed changes

• Add op_mode wrapper for mtr to enable ease of use + vrf functionality
• Re-introduce 'monitor traceroute' back to op_mode as requested by @c-po

How to test

• monitor traceroute 1.1.1.1
• monitor traceroute vrf mgmt 1.1.1.1
• mtr vrf blah 1.1.1.1

Checklist:

• I have read the CONTRIBUTING document
• I have linked this PR to one or more Phabricator Task(s)
• I have run the components SMOKETESTS if applicable
• My commit headlines contain a valid Task id
• My change requires a change to the documentation
• I have updated the documentation accordingly

[c-po]

In the past (VyOS 1.2) we had already a CLI for mtr under monitor traceroute which was removed in by 55d2ee8.

I have no strong bounds with monitor traceroute or mtr on the op-mode tree, but we probably should keep the well known monitor traceroute CLI tree as this was already there.

Original Implementation https://github.com/vyos/vyatta-op/blob/crux/templates/monitor/traceroute/node.tag/node.def
which was moved to XML in vyos-1x with f16633f but later got removed in 55d2ee8

Happy to re-add this with the nice CLI helper extension for 1.4 and 1.5 after the stray double whitespaces have been fixed and the CLI was changed to monitor traceroute

[bbabich]

What you suggest makes sense to me too @c-po - I believe all you've requested is now complete.
Seems the doco doesn't even need updating :)
https://github.com/vyos/vyos-documentation/blob/master/docs/troubleshooting/index.rst#advanced-connectivity-tests

[c-po]

Possible completions:
  <hostname>            Traceroute route with mtr
  <x.x.x.x>
  <h:h:h:h:h:h:h:h>


cpo@LR1.wue3:~$ monitor traceroute 1.1.1.1

 Invalid option: 1.1.1.1


Possible completions:
  <Enter>               Execute the current command
  <nocomps>             mtr options


cpo@LR1.wue3:~$ monitor traceroute 1.1.1.1
mtr: Unknown host: traceroute

Was this tested locally?

[c-po]

monitor traceroute 1.1.1.1 now works with 709c578 - CLI completion helper is still broken.

[c-po]

@Mergifyio backport sagitta

[mergify]

backport sagitta

✅ Backports have been created

• #2474 mtr: T5658: Add VRF support for mtr (+ op_mode wrapper) (backport #2435) has been created for branch sagitta

[bbabich]

monitor traceroute 1.1.1.1 now works with 709c578 - CLI completion helper is still broken.

Thanks for finishing this off and apologies for not sorting it out myself. A better outcome with your additional cleanup/fixes too anyhow.

I'll do better next time...