Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

image-tools: T5758: restore saving previous data on install #2580

Merged
merged 1 commit into from Dec 7, 2023

Conversation

jestabro
Copy link
Contributor

@jestabro jestabro commented Dec 7, 2023

Change Summary

Restore scanning previous installations for config data and ssh host keys on install.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):
    -- missing functionality of revision

Related Task(s)

Related PR(s)

Component(s) name

Proposed changes

How to test

Smoketest result

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

@jestabro jestabro self-assigned this Dec 7, 2023
@vyosbot vyosbot requested review from a team, dmbaturin, sarthurdev, zdc, sever-sever and c-po and removed request for a team December 7, 2023 04:16
@c-po
Copy link
Member

c-po commented Dec 7, 2023

I think a rebase operation went sideways as you include a commit (6d6b3fb) from @nicolas-fort.

Can you please rebase to the latest current version?

Restore scanning previous installations for config data and ssh host
keys on install.
@jestabro
Copy link
Contributor Author

jestabro commented Dec 7, 2023

I think a rebase operation went sideways as you include a commit (6d6b3fb) from @nicolas-fort.

Can you please rebase to the latest current version?

Thanks, @c-po !

@jestabro jestabro merged commit 264f23b into vyos:current Dec 7, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 participants