Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

image-tools: T5883: preserve file owner in /config on add system update #2731

Merged
merged 1 commit into from Jan 1, 2024

Conversation

jestabro
Copy link
Contributor

@jestabro jestabro commented Jan 1, 2024

Change Summary

The /config dir has the set-group-id bit set for group ownership when copying the directory on 'add system image'; user ownership is ignored as in general root is correct. However, for Kea dhcp leases stored in /config/dhcp, this will cause a problem --- preserver user on copy when updating.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Related PR(s)

Component(s) name

Proposed changes

How to test

Smoketest result

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

@jestabro jestabro self-assigned this Jan 1, 2024
@vyosbot vyosbot requested review from a team, dmbaturin, sarthurdev, zdc, sever-sever and c-po and removed request for a team January 1, 2024 04:52
@jestabro jestabro merged commit 27b9a45 into vyos:current Jan 1, 2024
8 checks passed
@jestabro
Copy link
Contributor Author

jestabro commented Jan 1, 2024

@Mergifyio backport sagitta

Copy link

mergify bot commented Jan 1, 2024

backport sagitta

✅ Backports have been created

c-po added a commit that referenced this pull request Jan 1, 2024
image-tools: T5883: preserve file owner in /config on add system update (backport #2731)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants