Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

T5897: frr should be stopped before vyos-router #2752

Merged
merged 1 commit into from Jan 4, 2024
Merged

T5897: frr should be stopped before vyos-router #2752

merged 1 commit into from Jan 4, 2024

Conversation

tjjh89017
Copy link
Contributor

Change Summary

FRR should be stopped before vyos-router.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Related PR(s)

Component(s) name

Proposed changes

How to test

Smoketest result

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

@tjjh89017
T5897: frr should be stopped before vyos-router
6d16ab0 
Signed-off-by: Date Huang <tjjh89017@hotmail.com>
@vyosbot vyosbot requested review from a team, dmbaturin, sarthurdev, zdc, jestabro, sever-sever and c-po and removed request for a team January 4, 2024 10:18
@sever-sever sever-sever merged commit 1043859 into vyos:current Jan 4, 2024
8 checks passed
@c-po
Copy link
Member

c-po commented Jan 4, 2024

@Mergifyio backport sagitta

@mergify Mergify
Copy link

mergify bot commented Jan 4, 2024 •
edited

backport sagitta

✅ Backports have been created

@mergify mergify bot mentioned this pull request Jan 4, 2024
Merged
c-po added a commit that referenced this pull request Jan 4, 2024
@c-po
Merge pull request #2753 from vyos/mergify/bp/sagitta/pr-2752
4f34e19 
T5897: frr should be stopped before vyos-router (backport #2752)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmbaturin dmbaturin dmbaturin approved these changes

@sever-sever sever-sever sever-sever approved these changes

@c-po c-po c-po approved these changes

@sarthurdev sarthurdev Awaiting requested review from sarthurdev sarthurdev was automatically assigned from vyos/reviewers

@zdc zdc Awaiting requested review from zdc zdc was automatically assigned from vyos/reviewers

@jestabro jestabro Awaiting requested review from jestabro jestabro was automatically assigned from vyos/reviewers

Assignees

@tjjh89017 tjjh89017

Labels
current
Milestone
No milestone
4 participants
@tjjh89017 @c-po @dmbaturin @sever-sever