Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

https: T6000: fix error in migration of path https certbot #2902

Merged
merged 1 commit into from Jan 30, 2024

Conversation

jestabro
Copy link
Contributor

@jestabro jestabro commented Jan 29, 2024

Change Summary

In migration https/5-to-6, check existence of, and subsequently delete, path
['service', 'https', 'certificates', 'certbot']
not
['service', 'https', 'certificates']

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Related PR(s)

Component(s) name

Proposed changes

How to test

Smoketest result

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

@jestabro jestabro self-assigned this Jan 29, 2024
@vyosbot vyosbot requested review from a team, dmbaturin, sarthurdev, zdc, sever-sever and c-po and removed request for a team January 29, 2024 18:41
@c-po
Copy link
Member

c-po commented Jan 30, 2024

@Mergifyio backport sagitta

@c-po c-po merged commit e79fd8f into vyos:current Jan 30, 2024
8 checks passed
Copy link

mergify bot commented Jan 30, 2024

backport sagitta

✅ Backports have been created

sever-sever added a commit that referenced this pull request Jan 30, 2024
https: T6000: fix error in migration of path https certbot (backport #2902)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 participants