Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ipsec: T5981: Strip '@' from migrated peer PKI name #2993

Merged
merged 1 commit into from Feb 12, 2024

Conversation

sarthurdev
Copy link
Member

@sarthurdev sarthurdev commented Feb 12, 2024

Change Summary

Strip '@' from migrated peer PKI name

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Related PR(s)

Component(s) name

ipsec

Proposed changes

  • Strip '@' from peer name for migrated PKI nodes as it fails the validator

How to test

Smoketest result

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

@vyosbot vyosbot requested review from a team, dmbaturin, zdc, jestabro, sever-sever and c-po and removed request for a team February 12, 2024 20:09
@sarthurdev
Copy link
Member Author

@Mergifyio backport sagitta

Copy link

mergify bot commented Feb 12, 2024

backport sagitta

✅ Backports have been created

@sarthurdev sarthurdev changed the title ipsec: T5981: Strip '@' from migrated peer name ipsec: T5981: Strip '@' from migrated peer PKI name Feb 12, 2024
@c-po c-po merged commit fe91476 into vyos:current Feb 12, 2024
8 checks passed
c-po added a commit that referenced this pull request Feb 12, 2024
ipsec: T5981: Strip '@' from migrated peer PKI name (backport #2993)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2 participants