Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

utils: T5239: add low-level read from config.boot (RPKI fixes) #3007

Merged
merged 1 commit into from
Feb 13, 2024

Conversation

c-po
Copy link
Member

@c-po c-po commented Feb 13, 2024

Change Summary

Backport from current codebase

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Related PR(s)

Component(s) name

Util helpers for vyos-router startup

Proposed changes

How to test

Smoketest result

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

@github-actions github-actions bot added the equuleus VyOS 1.3 LTS label Feb 13, 2024
@vyosbot vyosbot requested review from a team, dmbaturin, sarthurdev, zdc, jestabro and sever-sever and removed request for a team February 13, 2024 20:32
Copy link
Member

@dmbaturin dmbaturin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with the idea, but is the function really reusable? Maybe place it in the script itself?

@jestabro
Copy link
Contributor

jestabro commented Feb 13, 2024

I'll mention that I have had possible uses for the utility function, since initially writing it in this generality --- no actual use yet, but I would prefer to leave the option. Of course, the backport for equuleus could merge it in to the script, but perhaps unnecessary ...

@c-po c-po requested a review from dmbaturin February 13, 2024 20:52
@c-po c-po merged commit d095fd6 into vyos:equuleus Feb 13, 2024
4 checks passed
@c-po c-po deleted the rpki-fixes branch February 13, 2024 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
equuleus VyOS 1.3 LTS
4 participants