Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T6001: add option to disable next-hop-tracking resolve-via-default #3016

Merged
merged 3 commits into from Feb 16, 2024

Conversation

c-po
Copy link
Member

@c-po c-po commented Feb 16, 2024

Change Summary

  • set system ip nht no-resolve-via-default
  • set system ipv6 nht no-resolve-via-default
  • set vrf name <name> ip nht no-resolve-via-default
  • set vrf name <name> ipv6 nht no-resolve-via-default

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Related PR(s)

Component(s) name

Proposed changes

How to test

Smoketest result

cpo@LR1.wue3:~$ /usr/libexec/vyos/tests/smoke/cli/test_system_ip.py
test_system_ip_arp_table_size (__main__.TestSystemIP.test_system_ip_arp_table_size) ... ok
test_system_ip_directed_broadcast_forwarding (__main__.TestSystemIP.test_system_ip_directed_broadcast_forwarding) ... ok
test_system_ip_forwarding (__main__.TestSystemIP.test_system_ip_forwarding) ... ok
test_system_ip_multipath (__main__.TestSystemIP.test_system_ip_multipath) ... ok
test_system_ip_nht (__main__.TestSystemIP.test_system_ip_nht) ... ok
test_system_ip_protocol_non_existing_route_map (__main__.TestSystemIP.test_system_ip_protocol_non_existing_route_map) ... ok
test_system_ip_protocol_route_map (__main__.TestSystemIP.test_system_ip_protocol_route_map) ... ok

----------------------------------------------------------------------
Ran 7 tests in 37.873s

OK
cpo@LR1.wue3:~$ /usr/libexec/vyos/tests/smoke/cli/test_system_ipv6.py
test_system_ipv6_forwarding (__main__.TestSystemIPv6.test_system_ipv6_forwarding) ... ok
test_system_ipv6_multipath (__main__.TestSystemIPv6.test_system_ipv6_multipath) ... ok
test_system_ipv6_neighbor_table_size (__main__.TestSystemIPv6.test_system_ipv6_neighbor_table_size) ... ok
test_system_ipv6_nht (__main__.TestSystemIPv6.test_system_ipv6_nht) ... ok
test_system_ipv6_protocol_non_existing_route_map (__main__.TestSystemIPv6.test_system_ipv6_protocol_non_existing_route_map) ... ok
test_system_ipv6_protocol_route_map (__main__.TestSystemIPv6.test_system_ipv6_protocol_route_map) ... ok
test_system_ipv6_strict_dad (__main__.TestSystemIPv6.test_system_ipv6_strict_dad) ... ok

----------------------------------------------------------------------
Ran 7 tests in 38.751s

OK
cpo@LR1.wue3:~$ /usr/libexec/vyos/tests/smoke/cli/test_vrf.py
test_vrf_assign_interface (__main__.VRFTest.test_vrf_assign_interface) ... ok
test_vrf_bind_all (__main__.VRFTest.test_vrf_bind_all) ... ok
test_vrf_disable_forwarding (__main__.VRFTest.test_vrf_disable_forwarding) ... ok
test_vrf_ip_ipv6_nht (__main__.VRFTest.test_vrf_ip_ipv6_nht) ... ok
test_vrf_ip_ipv6_protocol_non_existing_route_map (__main__.VRFTest.test_vrf_ip_ipv6_protocol_non_existing_route_map) ... ok
test_vrf_ip_protocol_route_map (__main__.VRFTest.test_vrf_ip_protocol_route_map) ... ok
test_vrf_ipv6_protocol_route_map (__main__.VRFTest.test_vrf_ipv6_protocol_route_map) ... ok
test_vrf_link_local_ip_addresses (__main__.VRFTest.test_vrf_link_local_ip_addresses) ... ok
test_vrf_loopbacks_ips (__main__.VRFTest.test_vrf_loopbacks_ips) ... ok
test_vrf_static_route (__main__.VRFTest.test_vrf_static_route) ... ok
test_vrf_table_id_is_unalterable (__main__.VRFTest.test_vrf_table_id_is_unalterable) ... ok
test_vrf_vni_add_change_remove (__main__.VRFTest.test_vrf_vni_add_change_remove) ... ok
test_vrf_vni_and_table_id (__main__.VRFTest.test_vrf_vni_and_table_id) ... ok
test_vrf_vni_duplicates (__main__.VRFTest.test_vrf_vni_duplicates) ... ok

----------------------------------------------------------------------
Ran 14 tests in 218.954s

OK

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

EDB should be EGP for exterior gateway protocol
* set system ip nht no-resolve-via-default
* set system ipv6 nht no-resolve-via-default
… VRF context

* set vrf name <name> ip nht no-resolve-via-default
* set vrf name <name> ipv6 nht no-resolve-via-default
@c-po
Copy link
Member Author

c-po commented Feb 16, 2024

@Mergifyio backport sagitta

Copy link

mergify bot commented Feb 16, 2024

backport sagitta

✅ Backports have been created

@c-po c-po merged commit 8c860fa into vyos:current Feb 16, 2024
8 checks passed
@c-po c-po deleted the nht branch February 16, 2024 08:36
c-po added a commit that referenced this pull request Feb 16, 2024
T6001: add option to disable next-hop-tracking resolve-via-default (backport #3016)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2 participants