Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qos: T5646: Skip add filter for qos policy limiter class without match #3068

Merged
merged 1 commit into from Mar 4, 2024

Conversation

natali-rs1985
Copy link
Contributor

Change Summary

Adding filter for qos policy limiter class without match is skipped

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Related PR(s)

Component(s) name

qos

Proposed changes

How to test

set qos policy limiter my-policy class 10 bandwidth '20mbit'
set qos policy limiter my-policy class 10 match LOCAL-NET ip destination address '192.0.2.0/24'
set qos policy limiter my-policy class 20 bandwidth '10mbit'
set qos policy limiter my-policy default bandwidth '30mbit'
set qos interface eth1 ingress my-policy
commit

Smoketest result

test_01_cake (__main__.TestQoS.test_01_cake) ... ok
test_02_drop_tail (__main__.TestQoS.test_02_drop_tail) ... ok
test_03_fair_queue (__main__.TestQoS.test_03_fair_queue) ... ok
test_04_fq_codel (__main__.TestQoS.test_04_fq_codel) ... ok
test_05_limiter (__main__.TestQoS.test_05_limiter) ... ok
test_06_network_emulator (__main__.TestQoS.test_06_network_emulator) ... ok
test_07_priority_queue (__main__.TestQoS.test_07_priority_queue) ... ok
test_08_random_detect (__main__.TestQoS.test_08_random_detect) ... skipped 'tc returns invalid JSON here - needs iproute2 fix'
test_09_rate_control (__main__.TestQoS.test_09_rate_control) ... ok
test_10_round_robin (__main__.TestQoS.test_10_round_robin) ... ok
test_11_shaper (__main__.TestQoS.test_11_shaper) ... ok

----------------------------------------------------------------------
Ran 11 tests in 58.310s

OK (skipped=1)

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

@vyosbot vyosbot requested review from a team, dmbaturin, sarthurdev, zdc, jestabro, sever-sever and c-po and removed request for a team March 1, 2024 10:57
@dmbaturin dmbaturin merged commit 450bb16 into vyos:current Mar 4, 2024
8 checks passed
@dmbaturin
Copy link
Member

@Mergifyio backport sagitta

Copy link

mergify bot commented Mar 4, 2024

backport sagitta

✅ Backports have been created

c-po added a commit that referenced this pull request Mar 5, 2024
qos: T5646: Skip add filter for qos policy limiter class without match (backport #3068)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 participants